Older reviews (show 0 of 1 reproducible)
Do your own research!
Try out searching for "lost bitcoins", "stole my money" or "scammers" together with the wallet's name, even if you think the wallet is generally trustworthy. For all the bigger wallets you will find accusations. Make sure you understand why they were made and if you are comfortable with the provider's reaction.
The Analysis ¶
So the provider contacted us and cleared many issues we had in our first review. Let’s see how far we get this time …
First thing we notice is that there are still no build instructions on the GitHub page but according to above issue it’s simple enough:
The version we got from Google Play is this:
$ sha256sum BLW.apk ffcffa9d3053590b98f845622ab5a4748023245fbacc48f6798ca9ff753f86c6 BLW.apk $ apktool d -o BLW BLW.apk $ cat BLW/apktool.yml | grep "versionCode\|versionName" versionCode: '150' versionName: 0.4.4
$ git clone https://github.com/btcontract/lnwallet.git $ cd lnwallet $ git tag 0.4-146 0.4.1 0.4.1-147 0.4.2 0.4.3 0.4.4 $ git checkout 0.4.4 $ docker run -it --volume $PWD:/mnt --workdir /mnt --rm mycelium-wallet bash # wget https://downloads.gradle-dn.com/distributions/gradle-3.3-bin.zip # unzip gradle-3.3-bin.zip # /opt/android-sdk/tools/bin/sdkmanager ndk-bundle # ./gradle-3.3/bin/gradle assembleDebug Parallel execution is an incubating feature. Checking the license for package CMake 3.6.4111459 in /opt/android-sdk/licenses License for package CMake 3.6.4111459 accepted. Preparing "Install CMake 3.6.4111459 (revision: 3.6.4111459)". "Install CMake 3.6.4111459 (revision: 3.6.4111459)" ready. Finishing "Install CMake 3.6.4111459 (revision: 3.6.4111459)" Installing CMake 3.6.4111459 in /opt/android-sdk/cmake/3.6.4111459 "Install CMake 3.6.4111459 (revision: 3.6.4111459)" complete. "Install CMake 3.6.4111459 (revision: 3.6.4111459)" finished. Incremental java compilation is an incubating feature. FAILURE: Build failed with an exception. * What went wrong: A problem occurred configuring project ':app'. > No toolchains found in the NDK toolchains folder for ABI with prefix: mips64el-linux-android * Try: Run with --stacktrace option to get the stack trace. Run with --info or --debug option to get more log output. BUILD FAILED
Which is again the known issue from last time: The gradle version is outdated. It should be 3.1 or above but is defined as
# cat build.gradle | grep "tools\.build" classpath 'com.android.tools.build:gradle:2.3.0'
So if there is a good reason for using an old gradle version (2.3 is from early 2015), the team should explain that.
Sadly we again fail to compile due to lack of sufficiently clear build instructions and come to the verdict not verifiable.
We could not verify that the provided code matches the binary!
As part of our Methodology, we ask:Is the published binary matching the published source code? If not, we tag it
Published code doesn’t help much if it is not what the published app was built from. That is why we try to reproduce the binary. We
- obtain the binary from the provider
- compile the published source code using the published build instructions into a binary
- compare the two binaries
- we might spend some time working around issues that are easy to work around
If this fails, we might search if other revisions match or if we can deduct the source of the mismatch but generally consider it on the provider to provide the correct source code and build instructions to reproduce the build, so we usually open a ticket in their code repository.
In any case, the result is a discrepancy between the app we can create and the app we can find on the app store and any discrepancy might leak your backup to the server on purpose or by accident.
As we cannot verify that the source provided is the source the app was compiled from, this category is only slightly better than closed source but for now we have hope projects come around and fix verifiability issues.
Share onTwitter Facebook LinkedIn
Or embed a widget in your website
<iframe src="https://walletscrutiny.com/widget/#appId=android/com.lightning.walletapp&theme=auto&style=short" name="_ts" style="min-width:180px;border:0;border-radius:10px;max-width:280px;min-height:30px;"> </iframe>
<iframe src="https://walletscrutiny.com/widget/#appId=android/com.lightning.walletapp&theme=auto&style=long" style="max-width:100%;width:342px;border:0;border-radius:10px;min-height:290px;"> </iframe>